Skip to content
This repository has been archived by the owner on Jul 29, 2019. It is now read-only.

Timeline with start-time or end-time not working on iPhone or IE with Win10 #2696

Closed
helgphi opened this issue Feb 9, 2017 · 4 comments
Closed

Comments

@helgphi
Copy link

helgphi commented Feb 9, 2017

Hi,

tested a few thing about json and start: "2017-02-09 10:40:00" or end:"...." at different browsers. On Firefox everything is working fine. But on Safari or Chrome at iPhone (6Plus) the Item will fix positioned on left side.

When i change the json file from
"[{"id":1,"content":"Urlaub","start":"2017-02-06 11:00:00","end":"2017-02-08 11:30:00","group":17} (-> not working at iPhone, but Firefox at Windows 10)
to
"[{"id":1,"content":"Urlaub","start":"2017-02-06 11:00:00 pm","end":"2017-02-08 11:30:00 pm","group":17}
(-> not working at iPhone and Windows 10!)
So I think after this test, that my iPhone can't interpret the time after the date right (like Firefox at Windows 10 with "11:00:00 pm".
With date only "[{"id":1,"content":"Urlaub","start":"2017-02-06","end":"2017-02-08","group":17}" at Windows 10 and iPhone everything is working fine...

So is this a bug or do I something wrong?

@yotamberk
Copy link
Contributor

@helgphi a solution for this is to simply convert your time to ISOStrings.
It's not a good idea in general to give time fields a non-time value

@helgphi helgphi changed the title Timeline with start-time or end-time not working on iPhone Timeline with start-time or end-time not working on iPhone or IE with Win10 Feb 11, 2017
@helgphi
Copy link
Author

helgphi commented Feb 11, 2017

@yotamberk ok, sorry I don't know exactly what you mean, but every change of the format: "start":"2017-02-06 11:00:00","end":"2017-02-08 11:30:00" will kill the items in the timeline. By the way, the example "Data serialization" won't work on iPhone and IE under Win10: http://visjs.org/examples/timeline/dataHandling/dataSerialization.html
(when you delete the time-value and load it with the button again, then everything is working fine)

All items ar floated: left and overlayed.....so I think this is a Bug from vis or js and the interpretation of the value time....or I'm wrong?

@yotamberk
Copy link
Contributor

@helgphi It's not great behavior... We need to solve this

@bradh
Copy link
Contributor

bradh commented Feb 25, 2017

It would be nice to handle any time format, but 2017-02-06 11:00:00 is not a valid javascript date. It might be accepted by some browsers, but you need to use a standard (ISOString) format if you want it to work in any browsers.

I'll try to fix the example soon.

bradh added a commit to bradh/vis that referenced this issue Feb 26, 2017
yotamberk pushed a commit that referenced this issue May 2, 2017
* Add Gitter badge (#2179)

* do not generate source-maps in distribution version

* add 'dist' folder for deployment

* added Badges

* added codeclimate badge

* added @Tooa to the support team

* added badges from isitmaintained.com (#2517)

* do not ignore dist and test folders in master

* generated dist files for v4.18.0

* generated dist files for v4.18.1

* Cheap fix for bug #2795

* Update to PR #2826 to use newline format

* changed to v4.18.1-SNAPSHOT

* chore(docs): general improvements (#2652)

* removed NOTICE file

* updated license date range to include 2017

* chore(docs): updated support team members

* chore: updated dependencies and devDependencies (#2649)

* Fixes instanceof Object statements for objects from other windows and iFrames. (#2631)

* Replaces instanceof Object checks with typeof to prevent cross tab issues.

* Adds missing space.

* chore: removed google-analytics from all examples (#2670)

* chore(docs): Add note that PRs should be submitted against the `develop` branch (#2623)

Related to: #2618
Related to: #2620

* feat(timeline): Change setCustomTimeTitle title parameter to be a string or a function (#2611)

* change setCustomTimeTitle title parameter, Now could be an string or a function
* Fixed indent and spacing

* feat(timeline): refactor tooltip to only use one dom-element (#2662)

* feat(network): Allow for image nodes to have a selected or broken image (#2601)

* feat(tests): run mocha tests in travis ci (#2687)

* Added showX(YZ)Axis options to Graph3d (#2686)

* Added showX(YZ)Axis to Graph3d

* Added show_Axis options to docs and playground example

* Resolved merge conflict

* Added show_Axis options to docs and playground example

* fix(build): use babel version compatible with webpack@1.14 (#2693)

fixes #2685

* feat(docs): use babel preset2015 for custom builds (#2678)

* add link to a mentioned example (#2709)

* chore(lint): added support for eslint (#2695)

* Trivial typo fix in how_to_help doc. (#2714)

* fix(timeline): #2598 Flickering onUpdateTimeTooltip (#2702)

* Fix redraw order
* Fix error when option is not defined
* Allow template labels
* Add .travis.yml file
* Add experiment travis code
* Fix react example
* Add animation to onUpdateTooltip

* fix(timeline): #778 Tooltip does not work with background items in timeline (#2703)

* Fix redraw order
* Fix error when option is not defined
* Allow template labels
* Add .travis.yml file
* Add experiment travis code
* Fix react example
* Make items z-index default to 1

* Add initial tests for Timeline PointItem (#2716)

* fix(timeline): #2679 TypeError: Cannot read property 'hasOwnProperty' of null (#2735)

* Fix redraw order
* Fix error when option is not defined
* Allow template labels
* Add .travis.yml file
* Add experiment travis code
* Fix react example
* Fix bug in item editable

* feat(timeline): #2647 Dynamic rolling mode option (#2705)

* Fix redraw order
* Fix error when option is not defined
* Allow template labels
* Add .travis.yml file
* Add experiment travis code
* Fix react example
* Add toggleRollingMode option
* Update docs with toggleRollingMode option

* fixes timestep next issue (#2732)

* feat(timeline): added new locales for french and espanol (#2723)

* Fix eslint problem on Travis. (#2744)

* fix: Range.js "event" is undeclared (#2749)

* fix(timeline): #2720 Problems with option editable (#2743)

Clean up and centralise edit status for Timeline Items.

* feat(network): Improve the performance of the network layout engine (#2729)

* Improve the performance of the network layout engine

Short-cut the execution of a number of methods in LayoutEngine to make them
handle highly-connected graphs better.

* Demonstrations of layouts of large networks

* Added support to supply an end to bar charts to have them scale (#2760)

* Added support to supply an X2 to bar charts to have them scale

* Fixed graph2d stacking issue.  It no longer takes into account hidden items

* Changed x2 to end per recommendation and added this to the docs

* Initial tests for timeline ItemSet. (#2750)

Somewhat more complicated setup, associated with the need for a real window.

* [Timeline] Modify redraw logic to treat scroll as needing restack. (#2774)

This addresses #1982 and #1417.

It possibly reduces performance, but correctness seems better.

* fix(timeline): #2672 Item events original event (#2704)

* Fix redraw order

* Fix error when option is not defined

* Allow template labels

* Add .travis.yml file

* Add experiment travis code

* Fix react example

* Fix events returned from mouse events

* Fix example

* Rename censor to stringifyObject in example

* [timeline] Update examples to use ISOString format. (#2791)

Resolves #2790

* [timeline] Update serialization example to use ISOString dates. (#2789)

Resolves #2696

* added github templates for issues and pull-requests (#2787)

fixes #2418

* feat(timeline): Add item data as argument to the template function (#2799)

* Fix regression introduced in #2743. (#2796)

* Fix for issue #2536 (#2803)

* Fix for issue #2536

* Adjusted documentation for fix.

* Adjustments due to review

* Grrrrr whitespace

* Fixed Travis issue

* Cheap fix for bug #2795

* Update to PR #2826 to use newline format

* Update to gitignore to reflect changes on remote

* clean dist folder

* Local gitignore update

* Just a first example file for the week scale feature

* Allowing sourcemap creation

* Initial (non-functional) commit to ensure we insert code at the right places (check TODOs)

* Functional, not bug-free version which works with locale aware week numbers.

* Locale-aware implementation and simplified major labels to a full year

* Trying to make the major labels show the correct start date

* Working implementation of week numbers using localization.

* removing development leftovers

* Updated package.json

* Reintagrate package.json from accidental deletion

* Updates for package.json

* Fixing package.json

* Integrate the week numbers feature in the documentation.

* Reverting local changes to .gitignore

* Reverting local changes

* Extending examples to cover the case when 1st day of week and 1st day of month align; Fixing display bug so that week numbers are not repeated in minorLabels

* Putting the examples into a loop
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants