Adds action link for browse benefits page #3373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1pretz1
force-pushed
the
add-inset-text-for-browse-page
branch
from
68f17f2 to
1b1b6ad
Compare
1pretz1
force-pushed
the
add-inset-text-for-browse-page
branch
from
84bd69f to
b1da204
Compare
1pretz1
force-pushed
the
add-inset-text-for-browse-page
branch
from
fb1d16f to
5dd2cb2
Compare
1pretz1
force-pushed
the
add-inset-text-for-browse-page
branch
from
5dd2cb2 to
4a93a9e
Compare
1pretz1
changed the title
1pretz1
force-pushed
the
add-inset-text-for-browse-page
branch
5 times, most recently
from
5867368 to
ea21e41
Compare
1pretz1
added a commit
to alphagov/govuk_publishing_components
that referenced
this pull request
Sep 13, 2023
Uses the existing dark icon but makes it slightly larger as per the design recommendation for the new benefits calculator link being added to the browse benefit page. Related PR: alphagov/collections#3373
1pretz1
force-pushed
the
add-inset-text-for-browse-page
branch
from
ea21e41 to
27336ec
Compare
1pretz1
added a commit
to alphagov/govuk_publishing_components
that referenced
this pull request
Sep 13, 2023
Uses the existing dark icon but makes it slightly larger as per the design recommendation for the new benefits calculator link being added to the browse benefit page. Related PR: alphagov/collections#3373
1pretz1
added a commit
to alphagov/govuk_publishing_components
that referenced
this pull request
Sep 15, 2023
Uses the existing dark icon but makes it slightly larger as per the design recommendation for the new benefits calculator link being added to the browse benefit page. Related PR: alphagov/collections#3373
1pretz1
added a commit
to alphagov/govuk_publishing_components
that referenced
this pull request
Sep 15, 2023
Uses the existing dark icon but makes it slightly larger as per the design recommendation for the new benefits calculator link being added to the browse benefit page. Related PR: alphagov/collections#3373
1pretz1
force-pushed
the
add-inset-text-for-browse-page
branch
2 times, most recently
from
defc1cb to
ec0b441
Compare
We're now linking from the mainstream browse benefits page to the the financial support calculator. This feels a bit hacky as we're adding bespoke logic for one page, however the alternative would be to add functionality to Collections Publisher and then Collections which doesn't seem worthwhile. If we find multiple browse pages want this feature then we probably should look into adding the functionality to the publishing tool. Related PR: alphagov/govuk_publishing_components#3596 Trello: https://trello.com/c/mwQET0e0/2153-add-link-to-the-benefits-smart-answer-to-the-browse-benefits-page
1pretz1
force-pushed
the
add-inset-text-for-browse-page
branch
from
ec0b441 to
5071be9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're now linking from the mainstream browse benefits page to the the financial support calculator. More info in commits ->
Depends on: alphagov/govuk_publishing_components#3596
Before
After
Trello:
https://trello.com/c/mwQET0e0/2153-add-link-to-the-benefits-smart-answer-to-the-browse-benefits-page
Follow these steps if you are doing a Rails upgrade.