Add large dark icon for action link #3596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1pretz1
force-pushed
the
add-large-dark-icon
branch
from
b2a7534 to
7e24770
Compare
1pretz1
added a commit
to alphagov/collections
that referenced
this pull request
Sep 13, 2023
We're now linking from the mainstream browse benefits page to the the financial support calculator. This feels a bit hacky as we're adding bespoke logic for one page, however the alternative would be to add functionality to Collections Publisher and then Collections which doesn't seem worthwhile. If we find multiple browse pages want this feature then we probably should look into adding the functionality to the publishing tool. Related PR: alphagov/govuk_publishing_components#3596 Trello: https://trello.com/c/mwQET0e0/2153-add-link-to-the-benefits-smart-answer-to-the-browse-benefits-page
1pretz1
force-pushed
the
add-large-dark-icon
branch
from
7e24770 to
bd8de2f
Compare
jon-kirwan
reviewed
Sep 13, 2023
app/assets/stylesheets/govuk_publishing_components/components/_action-link.scss
Outdated
Show resolved
Hide resolved
1pretz1
force-pushed
the
add-large-dark-icon
branch
from
909cb48 to
3487943
Compare
Uses the existing dark icon but makes it slightly larger as per the design recommendation for the new benefits calculator link being added to the browse benefit page. Related PR: alphagov/collections#3373
1pretz1
force-pushed
the
add-large-dark-icon
branch
from
3487943 to
aed489a
Compare
|
Addressed the |
1pretz1
added a commit
to alphagov/collections
that referenced
this pull request
Sep 19, 2023
We're now linking from the mainstream browse benefits page to the the financial support calculator. This feels a bit hacky as we're adding bespoke logic for one page, however the alternative would be to add functionality to Collections Publisher and then Collections which doesn't seem worthwhile. If we find multiple browse pages want this feature then we probably should look into adding the functionality to the publishing tool. Related PR: alphagov/govuk_publishing_components#3596 Trello: https://trello.com/c/mwQET0e0/2153-add-link-to-the-benefits-smart-answer-to-the-browse-benefits-page
1pretz1
added a commit
to alphagov/collections
that referenced
this pull request
Sep 19, 2023
We're now linking from the mainstream browse benefits page to the the financial support calculator. This feels a bit hacky as we're adding bespoke logic for one page, however the alternative would be to add functionality to Collections Publisher and then Collections which doesn't seem worthwhile. If we find multiple browse pages want this feature then we probably should look into adding the functionality to the publishing tool. Related PR: alphagov/govuk_publishing_components#3596 Trello: https://trello.com/c/mwQET0e0/2153-add-link-to-the-benefits-smart-answer-to-the-browse-benefits-page
1pretz1
added a commit
to alphagov/collections
that referenced
this pull request
Sep 22, 2023
We're now linking from the mainstream browse benefits page to the the financial support calculator. This feels a bit hacky as we're adding bespoke logic for one page, however the alternative would be to add functionality to Collections Publisher and then Collections which doesn't seem worthwhile. If we find multiple browse pages want this feature then we probably should look into adding the functionality to the publishing tool. Related PR: alphagov/govuk_publishing_components#3596 Trello: https://trello.com/c/mwQET0e0/2153-add-link-to-the-benefits-smart-answer-to-the-browse-benefits-page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Uses the existing dark icon but makes it slightly larger as per the
design recommendation for the new benefits calculator link being added
to the browse benefit page.
Related PR: alphagov/collections#3373
Why
Current dark icon is too small and doesn't fit the recommended design.
Visual Changes
Large dark icon used for the new action link:
Trello:
https://trello.com/c/mwQET0e0/2153-add-link-to-the-benefits-smart-answer-to-the-browse-benefits-page