[DO NOT MERGE] Rebuild DGU's frontend #1123
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- should make the govuk_publishing_components guide available at /component-guide
- remove reliance on GOV.UK Elements - set legacy palette to false as deprecated in latest govuk-frontend - temporarily remove overrides and DGU component styles
- update application layout to use govuk-frontend markup structure - use govuk_publishing_components components for header, footer and breadcrumbs
- use govuk-frontend styles and components for the pages linked in the footer, including about, accessibility, cookies, privacy, terms and support - update cookie page JS in line with current govuk_publishing_components JS modules
- add basic mobile responsiveness - use govuk-frontend styles and components
- still in progress, commenting out some lines that currently cause the Sass compilation to error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a work in progress
What
Rework the frontend of DGU to include more use of existing styles and components from
govuk-frontendandgovuk_publishing_components. Currently in progress, still to do:Why
This has been partly prompted by upcoming changes to
govuk-frontend. The new version (4.4.0) deprecates some features relating to compatibility with older codebases, particularly GOV.UK Elements (which DGU still uses).Although DGU will work with 4.4.0 these features will be removed entirely in version 5.0.0, at which point DGU can no longer receive updates from
govuk_publishing_components(which is howgovuk-frontendis consumed) as the Sass will no longer compile.Visual changes
Homepage is broadly the same, although a lack of responsiveness on mobile is addressed (although this could be improved). Now uses the header and footer components from
govuk_publishing_components(although the omission of the crown logo in the current DGU heading may be deliberate and need further investigation).Accessibility page (as an example of miscellaneous pages linked to from the footer). Uses more consistent
govuk-frontendstyling.Cookies page.
Trello card: https://trello.com/c/kL8Aq73n/327-upgrade-dgus-frontend