[DO NOT MERGE] Upgrade govuk_publishing_components #1305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- should make the govuk_publishing_components guide available at /component-guide
- remove reliance on GOV.UK Elements - set legacy palette to false as deprecated in latest govuk-frontend - temporarily remove overrides and DGU component styles
- use component for header - move GA code into partial - use component for phase banner and add text/link - use govuk-frontend grid layout
- upgrade to last version before the more complex switch to govuk-frontend v5 - update manifest files and Sass to compile all CSS into one file - remove print stylesheet as no longer relevant - update Sass variables/mixins for newer govuk-frontend
- update en.yml to allow iteration
- no longer needed
- used by Rails to detect older IE - no longer needed
andysellick
force-pushed
the
fe-fixes
branch
from
7195731
to
6ba91a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update
govuk_publishing_componentsto a newer version, and make related frontend improvements, use newer components, etc.Based on work previously done in #1123
Why
Visual changes
Many! To be added.
Trello card: https://trello.com/c/yksZESKt/2816-spike-investigate-how-we-would-upgrade-datagovuk-to-latest-version-of-design-system-1-day