Use heading_level param instead of is_page_heading (radio component)
#1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The email frequency page uses a radio component with the is_page_heading parameter. Changes are being made to remove the is_page_heading parameter, and achieve the same result using heading_level and/or heading_size instead. This swaps is_page_heading for heading_level.
danacotoran
force-pushed
the
update-radios
branch
from
9d70dfd to
11e54a2
Compare
danacotoran
changed the title
heading_level param instead of is_page_heading (radio component)
owenatgov
approved these changes
May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🙅🏻♀️ Do not merge, depends on alphagov/govuk_publishing_components#2051 🙅🏻♀️(now up to date with the latest gem changes)
The email frequency page uses a radio component with the
is_page_headingparameter.Changes are being made to remove the
is_page_headingparameter, and achieve the same result usingheading_leveland/orheading_sizeinstead. The reasons behind this are described in more detail in this issue.This swaps
is_page_headingforheading_level1.