Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up redundancy within radio component #1953

Closed
danacotoran opened this issue Mar 2, 2021 · 0 comments
Closed

Clean up redundancy within radio component #1953

danacotoran opened this issue Mar 2, 2021 · 0 comments

Comments

@danacotoran
Copy link
Contributor

Recently the ability to pass a custom heading level was introduced to the radio component #1951

Since we've now got this option, the is_page_heading option is a bit redundant/confusing.
The is_page_heading parameter simply dictates that the heading be a h1 of size xl.
It is possible to retire is_page_heading and use heading_level and heading_size to achieve the same result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant