Use heading_level param instead of is_page_heading (radio component)
#5366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace is_page_heading: true with heading_level: 1 on the radio component. This is because changes are being made to remove is_page_heading and achieve the same outcome using heading_level and/or heading_size instead.
owenatgov
approved these changes
May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
is_page_heading: truewithheading_level: 1on the radio component.This is because changes are being made to remove
is_page_headingand achieve the same outcome usingheading_leveland/orheading_sizeinstead. Related issue where this is documented: alphagov/govuk_publishing_components#1953No visual changes should occur as a result of this update.