Fix column alignment in the "More on GOV.UK" homepage component #3253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickpatrickpatrick
suggested changes
Jun 7, 2022
|
I'm seeing an odd behaviour in Safari1 - when tabbing through the list of links, the "Check your State Pension age" link moves to the left column:
Then when tabbing to the next link, it reverts back to the second column:
This behaviour doesn't happen on the live version of the homepage. Footnotes
|
matthillco
force-pushed
the
mh-homepage-fix
branch
3 times, most recently
from
d5b49ad
to
ffd89d7
Compare
injms
reviewed
Jun 9, 2022
matthillco
force-pushed
the
mh-homepage-fix
branch
from
ffd89d7
to
5f3df65
Compare
In tablet view and above, the columns in this component were misaligned with the columns in the Featured component above. This is due to two incompatible layout approaches. Several approaches to align these elements were investigated, using combinations of float based layouts and CSS grid. However these approaches did not yield any compatible alignments, possibly due to differences in how browsers calculate `%` widths vs `fr` widths. The fix was to use CSS `columns` with a `column-gap` matching the gutter in the row/columns layout classes, and limiting the width of the list to two columns out of three (66.66%). This aligns the elements correctly while keeping the required top -> bottom then left -> right behaviour of the links. Note that the `break-inside: avoid-column` and the padding-top and padding-bottom tweaks are used to prevent triggering a possible bug in Safari where focused anchors in a multi-column layout cause links to jump between columns. As this is not a long-term robust solution, we should investigate this further for a possible refactor.
matthillco
force-pushed
the
mh-homepage-fix
branch
from
5f3df65
to
ce676f4
Compare
injms
approved these changes
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In tablet view and above, the columns in this component were misaligned with the columns in the Featured component above. This is due to two incompatible layout approaches.
Several approaches to align these elements were investigated, using combinations of float based layouts and CSS grid. However these approaches did not yield any compatible alignments, possibly due to differences in how browsers calculate
%widths vsfrwidths.The fix was to use CSS
columnswith acolumn-gapmatching the gutter in the row/columns layout classes, and limiting the width of the list to two columns out of three (66.66%). This aligns the elements correctly while keeping the required top -> bottom then left -> right behaviour of the links.Note that the
break-inside: avoid-columnand the padding-top and padding-bottom tweaks are used to prevent triggering a possible bug in Safari where focused anchors in a multi-column layout cause links to jump between columns. As this is not a long-term robust solution, we should investigate this further for a possible refactor.Heroku preview
Trello card
Visual changes
Before
After