Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focused link clipped in Chrome – Footer component, two column list layout #1888

Closed
danacotoran opened this issue Jul 29, 2020 · 6 comments
Closed
Labels

Comments

@danacotoran
Copy link

This issue seems to occur only when one of the columns has more navigation items than the other column (it's fine when the columns are equal).

What happens is that for some reason when the last link on the larger column is in focus, the link gets clipped.

It seems to have something to do with how Chrome applies the columns CSS properties.

Normal

Screenshot 2020-07-29 at 16 48 13

With two unequal columns

Screenshot 2020-07-29 at 16 48 28

@36degrees
Copy link
Contributor

Looking at https://stackoverflow.com/questions/17881923/box-shadow-trimmed-in-css-columns-in-chrome, transform: translateZ(0); seems like it might fix this.

(Think this is at least vaguely related to #1284, so in the longer term we might end up moving away from using CSS columns anyway)

@vanitabarrett
Copy link
Contributor

As mentioned in v4.0.0 prioritisation, we're going to do a timeboxed investigation into #1726 and #1539 first. It's possible that this issue might be fixed if we switch to a different layout system in the footer. We should make sure we keep this card in mind when doing any testing during that investigation.

@matthillco
Copy link

I've recently completed a small PR that may contain a fix for this, see here for further info: frontend/3253

@36degrees
Copy link
Contributor

I think the issue might have been fixed in Chrome 102.

Are we happy to close this on that basis?

Chrome 101

Footer with an odd number of links in a two-column layout. The last link in the first column is focused, but the black underline is thinner than it should be.

Chrome 102

Footer with an odd number of links in a two-column layout. The last link in the first column is focused and looks correct.

@36degrees 36degrees reopened this Jun 14, 2022
@vanitabarrett
Copy link
Contributor

Happy to close if this has been fixed @36degrees

@36degrees
Copy link
Contributor

@matthillco meant to say – thank you very much for pointing us towards your fix, really appreciate it. However it looks like the issue has been fixed as of Chrome 102 so it shouldn't be needed now 🤞🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants