-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Footer layout isn't aligned with content layout #1539
Comments
I've had a look into this, I think the way flexbox works means that even though the proportions are correct in certain scenarios the footer will not align with the main grid system. I have proposed a fix to improve the specific issues raised by Dave here for three columns: #1542 I believe to fix this we need to improve how the footer works: This will require a small but breaking change, so will put this against the 4.0.0 milestone |
We may want to look at #1284 at the same time as this. |
As discussed in v4 prioritisation, we think this work is important but it's quite broad at the moment. We should probably do a timeboxed investigation into this issue and this related one to explore a few different layout systems for the footer and see how they perform. We should keep in mind these other issues with the footer, some of which may be fixed by switching to a new layout system. |
As noticed on GovWifi, the flexbox auto layout used in the footer means that the columns do not lock into the grid.
Example from GovWifi
With equal content, the content is not distributed evenly, the first column takes up more space. Adding content to the second or third column will take away space from the first, which is why the GovWifi example looks almost right, but it's coincidental.
Recreated in the Prototype Kit
Is there anything we can add to the flexbox properties to ensure min or max width of content?
## Done when
Details of breaking change
The text was updated successfully, but these errors were encountered: