Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer layout isn't aligned with content layout #1539

Closed
2 tasks done
Tracked by #2274
dashouse opened this issue Aug 28, 2019 · 3 comments · Fixed by #2462
Closed
2 tasks done
Tracked by #2274

Footer layout isn't aligned with content layout #1539

dashouse opened this issue Aug 28, 2019 · 3 comments · Fixed by #2462
Assignees
Labels
breaking change 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) footer
Milestone

Comments

@dashouse
Copy link

dashouse commented Aug 28, 2019

As noticed on GovWifi, the flexbox auto layout used in the footer means that the columns do not lock into the grid.

Example from GovWifi
Screen Shot 2019-08-28 at 11 53 40

With equal content, the content is not distributed evenly, the first column takes up more space. Adding content to the second or third column will take away space from the first, which is why the GovWifi example looks almost right, but it's coincidental.

Recreated in the Prototype Kit
Screen Shot 2019-08-28 at 11 52 15

Is there anything we can add to the flexbox properties to ensure min or max width of content?

## Done when

  • TBC
  • "Details of breaking change" section below completed to help with writing release notes

Details of breaking change

  • which users are affected: TBC
  • the change that’s been made: TBC
  • changes users will have to make: TBC
  • impact of users not making those changes: TBC
@NickColley NickColley added the 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) label Aug 28, 2019
@NickColley
Copy link
Contributor

I've had a look into this, I think the way flexbox works means that even though the proportions are correct in certain scenarios the footer will not align with the main grid system.

I have proposed a fix to improve the specific issues raised by Dave here for three columns: #1542

I believe to fix this we need to improve how the footer works:
https://github.com/alphagov/govuk-frontend/tree/spike-only-default-two-thirds-footer-for-two-sections

This will require a small but breaking change, so will put this against the 4.0.0 milestone

@NickColley NickColley added this to the v4.0.0 milestone Sep 2, 2019
@36degrees
Copy link
Contributor

We may want to look at #1284 at the same time as this.

@vanitabarrett
Copy link
Contributor

vanitabarrett commented Sep 8, 2021

As discussed in v4 prioritisation, we think this work is important but it's quite broad at the moment. We should probably do a timeboxed investigation into this issue and this related one to explore a few different layout systems for the footer and see how they perform.

We should keep in mind these other issues with the footer, some of which may be fixed by switching to a new layout system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) footer
Projects
6 participants