Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to the footer component #1680

Open
1 task
36degrees opened this issue Dec 19, 2019 · 1 comment
Open
1 task

Improvements to the footer component #1680

36degrees opened this issue Dec 19, 2019 · 1 comment
Labels
epic Epics are used in planning project boards to group related stories footer

Comments

@36degrees
Copy link
Contributor

36degrees commented Dec 19, 2019

The footer has a number of (~minor) layout issues that are hard to address without making changes to the markup. It also has a number of hardcoded English strings which we should address, aligning with supporting multiple languages.

Some of these fixes will involve making breaking changes.

We should also review the backlog entry for the Footer component to see if there are any other outstanding issues we should be looking to address.

Stories

Should

Could

Not prioritised yet

Done when

  • Review from GOV.UK Publishing before releasing
@36degrees 36degrees added the epic Epics are used in planning project boards to group related stories label Dec 19, 2019
@trang-erskine trang-erskine added this to the v4.0.0 milestone Sep 14, 2020
@DouglasCaven
Copy link

The new version of the Axe Review accessibility tool has highlighted a potential issue suggesting the ‘Crown copyright’ logo in the footer must have sufficient colour contrast. The failure is actually the logo and the colour of text passed and thought it should be noted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic Epics are used in planning project boards to group related stories footer
Projects
None yet
Development

No branches or pull requests

5 participants