Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari alignment issue with Footer list containing odd number of items #1284

Open
frankieroberto opened this issue Apr 24, 2019 · 2 comments
Labels
footer 🕔 hours A well understood issue which we expect to take less than a day to resolve. 🔍 investigation

Comments

@frankieroberto
Copy link
Contributor

The footer with secondary navigation and links to meta information component has a small bug which is only visible in desktop Safari.

If there's an odd number of items in the list, the right hand side has some extra whitespace at the top causing the links to be un-aligned:

Screenshot 2019-04-24 at 11 29 48

You can replicate this by removing the "Benefits" item from the list in the example using the Web inspector.

@vanitabarrett
Copy link
Contributor

As mentioned in v4.0.0 prioritisation, we're going to do a timeboxed investigation into #1726 and #1539 first. It's possible that this issue might be fixed if we switch to a different layout system in the footer. We should make sure we keep this card in mind when doing any testing during that investigation.

@querkmachine
Copy link
Member

When reproducing this for reporting to the WebKit team, it appears that a major cause of this issue is due to the final item in the list having the bottom margin removed. Restoring the margin fixes the layout issue.

We currently remove the bottom margin of the final list item so that there isn't a larger than desired space below the list when it appears as a single column (= container margin + list item margin), but given we're switching to columns on the basis of a media query anyway, it may be possible for us to rectify this issue in our own code by making this margin removal conditional on a media query.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
footer 🕔 hours A well understood issue which we expect to take less than a day to resolve. 🔍 investigation
Projects
None yet
Development

No branches or pull requests

7 participants