Add share buttons to consultations #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Port social media icons from Whitehall, remove unused icons and PNGCrush * Simplify markup and CSS for social icons * Look and behaviour matches Whitehall
Save 4% of bytes: TOTAL was: 11.503kb now: 11.038kb saving: .465kb (4.00%) quality: 100%
Show the button in purple when it matches the visited state. With a purple link and a blue button it looks like a mistake. Also use active and hover colours to match full link behaviour.
tvararu
approved these changes
Dec 19, 2016
| @@ -0,0 +1,26 @@ | |||
| window.GOVUK.Modules = window.GOVUK.Modules || {}; | |||
There was a problem hiding this comment.
This file uses a mix of semicolons and no semicolons but I don't mind it.
There was a problem hiding this comment.
Updated to match JS Standard style.
* Tracking ported from Whitehall * Set up and include first JS in government-frontend
On mobile devices containers using this class would still be shifted right by a few 100 pixels.
fofr
force-pushed
the
share-consultations
branch
from
24e221f to
97085c3
Compare
|
Looks good to @bevanloon and I.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
offset-one-thirdbug on thin devices(This is the first JS added to government-frontend. I'd like to include
jasmine-railsfor JS tests but I had problems running versions 12+ against PhantomJS 1.9.7 on our VM. I will try and fix in a separate PR) Edit: #208https://trello.com/c/MaZ7t0zi/521-add-share-buttons-to-consultations-on-government-frontend
Whitehall
This PR