-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add share buttons to consultations #207
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a21542e
Add share buttons to consultations
fofr f043371
PNG crush image assets
fofr f0d80b3
Use link colours for share buttons
fofr 59cb8df
Add javascript tracking of share buttons
fofr 97085c3
Only offset column on tablet and above
fofr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
//= require_tree ./modules |
26 changes: 26 additions & 0 deletions
26
app/assets/javascripts/modules/track-share-button-clicks.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
window.GOVUK.Modules = window.GOVUK.Modules || {}; | ||
|
||
(function (GOVUK) { | ||
'use strict' | ||
|
||
GOVUK.Modules.TrackShareButtonClicks = function () { | ||
this.start = function (element) { | ||
element.on('click', '.js-share-facebook', trackFacebook) | ||
element.on('click', '.js-share-twitter', trackTwitter) | ||
|
||
function trackFacebook () { | ||
trackShare('facebook') | ||
} | ||
|
||
function trackTwitter () { | ||
trackShare('twitter') | ||
} | ||
|
||
function trackShare (network) { | ||
if (GOVUK.analytics && GOVUK.analytics.trackShare) { | ||
GOVUK.analytics.trackShare(network) | ||
} | ||
} | ||
} | ||
} | ||
})(window.GOVUK) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
@mixin share-buttons { | ||
$share-button-width: 25px; | ||
$share-button-height: 25px; | ||
|
||
.share-buttons { | ||
@include core-16; | ||
margin-top: $gutter-one-third; | ||
|
||
.share-button-link { | ||
margin-right: $gutter; | ||
|
||
.share-button { | ||
display: inline-block; | ||
width: $share-button-width; | ||
height: $share-button-height; | ||
margin-right: $gutter-one-third; | ||
background-color: $link-colour; | ||
background-image: image-url("social-icons-white.png"); | ||
background-repeat: no-repeat; | ||
vertical-align: top; | ||
} | ||
|
||
&:visited .share-button { | ||
background-color: $link-visited-colour; | ||
} | ||
|
||
&:active .share-button { | ||
background-color: $link-active-colour; | ||
} | ||
|
||
&:hover .share-button { | ||
background-color: $link-hover-colour; | ||
} | ||
} | ||
|
||
.share-button-facebook { | ||
background-position: -2px -2px; | ||
} | ||
|
||
.share-button-twitter { | ||
background-position: -2px -32px; | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file uses a mix of semicolons and no semicolons but I don't mind it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to match JS Standard style.