Add temporary container to published-dates #2330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to prevent the change in this PR being a breaking one: alphagov/govuk_publishing_components#2558 Once the change above has been rolled out to government-frontend, the additional container can be removed, and the id of the container updated from "history" to "full-publication-update-history"
danacotoran
force-pushed
the
temp-workaround-for-metadata-link
branch
from
fc045f7 to
e094ba2
Compare
danacotoran
added a commit
that referenced
this pull request
Jan 17, 2022
PR #2330 added an additional div around published-dates to prevent this change in govuk_publishing_components being a breaking one: alphagov/govuk_publishing_components#2558 This additional div is now safe to remove and the id of the wrapper for published-dates can be updated to the new one.
danacotoran
added a commit
that referenced
this pull request
Jan 17, 2022
PR #2330 added an additional div around published-dates to prevent this change in govuk_publishing_components being a breaking one: alphagov/govuk_publishing_components#2558 This additional div is now safe to remove and the id of the wrapper for published-dates can be updated to the new one.
danacotoran
added a commit
that referenced
this pull request
Feb 1, 2022
…ata-link Undo temporary workaround in pull request #2330
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to prevent the change in this PR being a breaking one:
alphagov/govuk_publishing_components#2558
Once the change above has been rolled out to
government-frontend, theadditional container can be removed, and the id of the component wrapper updated
from "history" to "full-publication-update-history"