Make metadata component "See all updates" link href less generic #2561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using #history is too generic and causing problems as described in this issue: #600 Change the href to something less generic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
#historyis too generic and causing problems as described in this issue #600This changes the href to something less generic.
To prevent this being a breaking change in
government-frontend, I opened this PR which temporarily adds a container with the updated id around thepublished-datescomponent.Once the change in this PR has been rolled out to
government-frontend, the additional container can be removed, and the id of the component wrapper updated from "history" to "full-publication-update-history".