Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metadata and document footer anchor link is too generic #600

Closed
NickColley opened this issue Jul 10, 2017 · 1 comment · Fixed by alphagov/government-frontend#2337
Closed

Metadata and document footer anchor link is too generic #600

NickColley opened this issue Jul 10, 2017 · 1 comment · Fixed by alphagov/government-frontend#2337
Assignees
@danacotoran
Labels
bug in progress In progress issues are being worked on but may not be a high priority.

Comments

@NickColley
Copy link
Contributor

As seen in https://www.gov.uk/government/collections/new-a-level-and-as-level-qualifications-requirements-and-guidance#history

When pressing 'see all updates' in the metadata component, it'll anchor to some content in govspeak rather than the document footer component.

We could change this ID to be something more specific.

Related files:
@fofr fofr changed the title Metadata and document footer anchor link is too vague Metadata and document footer anchor link is too generic Sep 22, 2017
@tijmenb tijmenb transferred this issue from alphagov/static Nov 1, 2018
@NickColley NickColley added bug and removed usability labels Mar 31, 2020
@owenatgov
Copy link
Contributor

Would require an update to the metadata component in the components gem and in the publishing dates app component in government frontend.

There's research to suggest that this functionality might be a bit iffy so this might require a bit of more detailed design input in the future.

@andysellick andysellick added the in progress In progress issues are being worked on but may not be a high priority. label Nov 1, 2021
danacotoran added a commit that referenced this issue Jan 7, 2022
@danacotoran
Option to modify metadata "See all updates" link
a050f84 
Add option to change the metadata component "See all updates" link href
to something else. This is because #history is too generic which is
causing problems as described in this issue:
#600
danacotoran added a commit that referenced this issue Jan 7, 2022
@danacotoran
Make See all updates link href less generic
d72c0ae 
Using #history is too generic and causing problems as described in this
issue:

#600

Change the href to something less generic. This will be a breaking
change in government-frontend. When rolling out this change in
government-frontend, the id of the published-dates component should be
updated accordingly or the in-page link will not work.
danacotoran added a commit that referenced this issue Jan 7, 2022
@danacotoran
Make See all updates link href less generic
1bda110 
Using #history is too generic and causing problems as described in this
issue:

#600

Change the href to something less generic.
@danacotoran danacotoran mentioned this issue Jan 7, 2022
Closed
danacotoran added a commit that referenced this issue Jan 7, 2022
@danacotoran
Make See all updates link href less generic
73cc53f 
Using #history is too generic and causing problems as described in this
issue:

#600

Change the href to something less generic.
danacotoran added a commit that referenced this issue Jan 7, 2022
@danacotoran
Make See all updates link href less generic
8474d71 
Using #history is too generic and causing problems as described in this
issue:

#600

Change the href to something less generic.
alex-ju pushed a commit that referenced this issue Jan 7, 2022
@danacotoran @alex-ju
Make See all updates link href less generic
651bbb2 
Using #history is too generic and causing problems as described in this
issue:

#600

Change the href to something less generic.
@danacotoran danacotoran mentioned this issue Jan 7, 2022
Closed
danacotoran added a commit that referenced this issue Jan 7, 2022
@danacotoran
Make "See all updates" link href less generic
b76d5f7 
Using #history is too generic and causing problems as described in this
issue:
#600

Change the href to something less generic.
@danacotoran danacotoran mentioned this issue Jan 7, 2022
Closed
@alex-ju alex-ju mentioned this issue Jan 7, 2022
Merged
danacotoran added a commit that referenced this issue Jan 11, 2022
@danacotoran
Make See all updates link href less generic
eb1446f 
Using #history is too generic and causing problems as described in this
issue:

#600

Change the href to something less generic.
@danacotoran danacotoran mentioned this issue Jan 17, 2022
Merged
@injms injms assigned danacotoran and unassigned andysellick and owenatgov Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danacotoran danacotoran

Labels
bug in progress In progress issues are being worked on but may not be a high priority.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Undo temporary workaround in pull request #2330 alphagov/government-frontend
5 participants
@alex-ju @andysellick @NickColley @danacotoran @owenatgov