Skip to content

Commit

Permalink
Make See all updates link href less generic
Browse files Browse the repository at this point in the history
Using #history is too generic and causing problems as described in this
issue:

#600

Change the href to something less generic.
  • Loading branch information
danacotoran committed Jan 7, 2022
1 parent 5075e11 commit 8474d71
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
* Remove jQuery from static analytics ([PR #2526](https://github.com/alphagov/govuk_publishing_components/pull/2526))
* Remove unused scrolltracker ([PR #2551](https://github.com/alphagov/govuk_publishing_components/pull/2551))
* Tweak metadata component "See all updates" interaction ([PR #2552](https://github.com/alphagov/govuk_publishing_components/pull/2552))
* Make metadata component "See all updates" link href less generic ([PR #2558](https://github.com/alphagov/govuk_publishing_components/pull/2558))

## 28.0.0

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
<dd class="gem-c-metadata__definition">
<%= last_updated %>
<% if local_assigns.include?(:see_updates_link) %>
&#8212; <a href="#history" class="gem-c-metadata__definition-link govuk-!-display-none-print js-see-all-updates-link"
&#8212; <a href="#full-publication-update-history" class="gem-c-metadata__definition-link govuk-!-display-none-print js-see-all-updates-link"
data-track-category="content-history"
data-track-action="see-all-updates-link-clicked"
data-track-label="history">
Expand Down

0 comments on commit 8474d71

Please sign in to comment.