Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default heading size and update guidance #1201

Merged
merged 2 commits into from
Apr 9, 2020
Merged

Change default heading size and update guidance #1201

merged 2 commits into from
Apr 9, 2020

Conversation

christopherthomasdesign
Copy link
Member

Made some changes to:

  • change the default heading size on examples from govuk-heading-xl to govuk-heading-l
  • adjust the guidance on headings to reflect this change

Closes 698

@govuk-design-system-ci
Copy link
Collaborator

govuk-design-system-ci commented Mar 17, 2020 •
edited
Loading

You can preview this change here:

Built with commit 3ab5c38

https://deploy-preview-1201--govuk-design-system-preview.netlify.com

@christopherthomasdesign christopherthomasdesign marked this pull request as ready for review April 8, 2020 15:49
timpaul
timpaul approved these changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@timpaul timpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! It already feels like the headings were always this size, which is probably a good sign

@christopherthomasdesign christopherthomasdesign merged commit 415df5a into master Apr 9, 2020
@christopherthomasdesign christopherthomasdesign deleted the heading-sizes branch April 9, 2020 09:29
@edwardhorsford
Copy link
Contributor

edwardhorsford commented Apr 9, 2020 •
edited
Loading

🎉 AMAZING! 🎉

Thanks @christopherthomasdesign!

@timpaul

Good stuff! It already feels like the headings were always this size, which is probably a good sign

[cough] they did used to be this size [/cough]

@christopherthomasdesign christopherthomasdesign mentioned this pull request May 20, 2020
Merged
@edwardhorsford edwardhorsford mentioned this pull request Jan 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickColley NickColley NickColley left review comments

@timpaul timpaul timpaul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default heading sizes and guidance
5 participants
@christopherthomasdesign @govuk-design-system-ci @edwardhorsford @timpaul @NickColley