Fix duplicated examples on label and legend headings page #1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36degrees
approved these changes
May 20, 2020
|
You can preview this change here: Built with commit ad681ef https://deploy-preview-1262--govuk-design-system-preview.netlify.app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix an error made in #1201
The Making labels and legends headings page is currently showing duplicated examples:
I've removed the second example in each:
Before #1201, the examples included both a
landxlsize. However, I think since we're changing our default heading size tolnow, I think showing thexlexample here again could be confusing and inconsistent with our other guidance. Happy to add back in if others feel strongly about keeping it though.