Add guidance for text align override classes #1902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ You can preview this change here: 🔨 Explore the source changes: ac7b78b 🔍 Inspect the deploy log: https://app.netlify.com/sites/govuk-design-system-preview/deploys/6151b1df72bdd60007848b77 😎 Browse the preview: https://deploy-preview-1902--govuk-design-system-preview.netlify.app |
calvin-lau-sig7
commented
Sep 27, 2021
calvin-lau-sig7
commented
Sep 27, 2021
Add guidance for newly-added text override classes in Frontend: alphagov/govuk-frontend#2339 Put override classes into grey code boxes Correct 'centre' in class name
calvin-lau-sig7
force-pushed
the
calvin-lau-sig7-add-text-align-guidance
branch
from
76a1775 to
ac7b78b
Compare
vanitabarrett
approved these changes
Sep 28, 2021
|
This can be merged once #1898 is done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1863
Add guidance for newly-added text override classes in Frontend: alphagov/govuk-frontend#2339
Co-authored-by: @hannalaakso