Add text-align override classes
#2339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2339
2 tasks
hannalaakso
force-pushed
the
add-alignment-classes
branch
from
3dfe3ba to
0547ab2
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2339
|
Hmm, I see what you're saying about the examples being odd, maybe it would be more useful to show examples using them to align text in a table? |
36degrees
approved these changes
Sep 15, 2021
There was a problem hiding this comment.
Changes make sense to me – thanks @hannalaakso! Agree with Laurence that it'd be useful to have examples that show how the classes work with tables – especially as that's the original use case that was identified.
Personally not sure how important it is to have the panel example – I'd be happy with just text overridden, even though the 'natural' alignment would be left anyway. You can still use dev tools to check that the alignment is coming explicitly from the override.
hannalaakso
force-pushed
the
add-alignment-classes
branch
from
0547ab2 to
bd29c22
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2339
lfdebrux
approved these changes
Sep 17, 2021
calvin-lau-sig7
added a commit
to alphagov/govuk-design-system
that referenced
this pull request
Sep 27, 2021
Add guidance for newly-added text override classes in Frontend: alphagov/govuk-frontend#2339
calvin-lau-sig7
added a commit
to alphagov/govuk-design-system
that referenced
this pull request
Sep 27, 2021
Add guidance for newly-added text override classes in Frontend: alphagov/govuk-frontend#2339 Put override classes into grey code boxes Correct 'centre' in class name
EoinShaughnessy
changed the title
text align override classes
EoinShaughnessy
changed the title
text align override classestext-align override classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
text-alignproperty toleft,rightorcenter.The review app example used for
govuk-!-text-align-leftis a bit odd, feel free to suggest a better one (this would also be useful for when we add an example to the Design System guidance).Related: alphagov/govuk-design-system#1863
Fixes #1824