Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text-align override classes #2368

Merged
merged 2 commits into from
Sep 28, 2021

Conversation

vanitabarrett
Copy link
Contributor

@vanitabarrett vanitabarrett commented Sep 27, 2021

Note: this PR cherry-picks commits from #2339 in order to merge and release them from a support branch. Ordinarily, this fix would be made in the support branch first, and then copied over to main. However, in this instance, we're testing out the support branch release process in a slightly artificial scenario - the change has already been made (unreleased) in main, but we want to trial out releasing it from the support/v3.x branch

This PR:

  • Adds text align override classes that set the CSS text-align property to left, right or center.
  • Adds examples to the review app

The review app example used for govuk-!-text-align-left is a bit odd, feel free to suggest a better one (this would also be useful for when we add an example to the Design System guidance). edit: resolved

Related: alphagov/govuk-design-system#1863

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2368 September 27, 2021 15:30 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2368 September 27, 2021 15:31 Inactive
@vanitabarrett vanitabarrett changed the base branch from main to support/3.x September 27, 2021 15:32
@vanitabarrett vanitabarrett marked this pull request as ready for review September 27, 2021 15:36
@EoinShaughnessy EoinShaughnessy changed the title Add text-align override classes Add text-align override classes Sep 28, 2021
@vanitabarrett vanitabarrett merged commit d8a651d into support/3.x Sep 28, 2021
@vanitabarrett vanitabarrett deleted the add-override-alignment-classes branch September 28, 2021 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants