Throw error when section content is missing

alphagov · Oct 19, 2023 · 53a2a6a · 53a2a6a
1 parent 0bc19c0
commit 53a2a6a
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 1 deletion.
diff --git a/packages/govuk-frontend/src/govuk/components/accordion/accordion.mjs b/packages/govuk-frontend/src/govuk/components/accordion/accordion.mjs
@@ -411,7 +411,22 @@ export class Accordion extends GOVUKFrontendComponent {
     const $button = $section.querySelector(`.${this.sectionButtonClass}`)
     const $content = $section.querySelector(`.${this.sectionContentClass}`)
 
-    if (!$showHideIcon || !$showHideText || !$button || !$content) {
+    if (!$button) {
+      throw new ElementError({
+        componentName: 'Accordion',
+        identifier: `Section button (\`.${this.sectionButtonClass}\`)`
+      })
+    }
+
+    if (!$content) {
+      throw new ElementError({
+        componentName: 'Accordion',
+        identifier: `Section content (\`.${this.sectionContentClass}\`)`
+      })
+    }
+
+    if (!$showHideIcon || !$showHideText) {
+      // Return early for elements we create
       return
     }
 

diff --git a/packages/govuk-frontend/src/govuk/components/accordion/accordion.puppeteer.test.js b/packages/govuk-frontend/src/govuk/components/accordion/accordion.puppeteer.test.js
@@ -832,6 +832,23 @@ describe('/components/accordion', () => {
               'Accordion: Section button (`.govuk-accordion__section-button`) not found'
           })
         })
+
+        it('throws when any section content is missing', async () => {
+          await expect(
+            renderAndInitialise(page, 'accordion', examples.default, {
+              beforeInitialisation($module, { selector }) {
+                $module.querySelector(selector).remove()
+              },
+              context: {
+                selector: '.govuk-accordion__section-content'
+              }
+            })
+          ).rejects.toEqual({
+            name: 'ElementError',
+            message:
+              'Accordion: Section content (`.govuk-accordion__section-content`) not found'
+          })
+        })
       })
     })
   })