Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to new Chrome headless mode #3541

Closed
1 task
colinrotherham opened this issue Apr 24, 2023 · 1 comment · Fixed by #3543
Closed
1 task

Switch to new Chrome headless mode #3541

colinrotherham opened this issue Apr 24, 2023 · 1 comment · Fixed by #3543

Comments

@colinrotherham
Copy link
Contributor

colinrotherham commented Apr 24, 2023

What

We're getting lots of warnings about Chrome { headless: true } related to the new headless mode in v112

Chrome’s Headless mode gets an upgrade: introducing --headless=new
https://developer.chrome.com/articles/new-headless/

We should investigate and switch to { headless: 'new' } unless we hit issues:

Technically, the old Headless was a separate, alternate browser implementation that happened to be shipped as part of the same Chrome binary. It doesn’t share any of the Chrome browser code in //chrome.

Why

It's important that we

  • Test using the same Chrome browser as our users
  • Identify Chrome issues early before new headless mode is the default

Who needs to work on this

Developers

Who needs to review this

Developers

Done when

  • Switch to new Chrome headless mode
@colinrotherham
Copy link
Contributor Author

Can confirm it's rather noisy 🤦‍♂️ since we merged:

Puppeteer old Headless deprecation warning:
    In the near feature `headless: true` will default to the new Headless mode
    for Chrome instead of the old Headless implementation. For more
    information, please see [https://developer.chrome.com/articles/new-headless/.](https://developer.chrome.com/articles/new-headless/)
    Consider opting in early by passing `headless: "new"` to `puppeteer.launch()`
    If you encounter any bugs, please report them to https://github.com/puppeteer/puppeteer/issues/new/choose.

Console spam from Puppeteer

colinrotherham added a commit that referenced this issue Apr 24, 2023
Prevents the warning by defaulting to `undefined` (not `true`) until we investigate “new” headless mode in: #3541
colinrotherham added a commit that referenced this issue Apr 24, 2023
Prevents the warning by defaulting to `1` (not `true`) until we investigate “new” headless mode in: #3541
colinrotherham added a commit that referenced this issue Apr 24, 2023
Prevents the warning by defaulting to `1` (not `true`) until we investigate “new” headless mode in: #3541
@colinrotherham colinrotherham linked a pull request Apr 25, 2023 that will close this issue
@colinrotherham colinrotherham moved this from Backlog 🗄 to Needs review 🔍 in GOV.UK Design System cycle board May 17, 2023
@colinrotherham colinrotherham moved this from Needs review 🔍 to Done 🏁 in GOV.UK Design System cycle board May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

1 participant