Prevent Chrome headless deprecation warning #3542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinrotherham
added
🐛 bug
colinrotherham
commented
Apr 24, 2023
jest-puppeteer.config.js
Outdated
| * {@link https://developer.chrome.com/articles/new-headless/} | ||
| */ | ||
| headless: process.env.HEADLESS !== 'false' | ||
| ? undefined |
There was a problem hiding this comment.
By defaulting to { headless: undefined } we skip the deprecation checks in:
There was a problem hiding this comment.
@domoscargin Sadly they're using const headless = options.headless ?? true; which compiles to:
const headless = (_a = options.headless) !== null && _a !== void 0 ? _a : true;But we can default to 1 instead of undefined to make this work
|
I've raised this with the Puppeteer team as the intention probably wasn't to throw up 11x warnings per test run: |
colinrotherham
force-pushed
the
chrome-headless-warning
branch
from
391917f to
08fce87
Compare
2 tasks
Prevents the warning by defaulting to `1` (not `true`) until we investigate “new” headless mode in: #3541
colinrotherham
force-pushed
the
chrome-headless-warning
branch
from
08fce87 to
9a16037
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents the recent Puppeteer
{ headless: true }deprecation warning:headless: truepuppeteer/puppeteer#10039We can revisit this in future with “new” headless mode via:
Until then it prevents all the console spam we're getting: