Add support for attributes on table cells #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It’s currently not possible to attach HTML attributes to table cells. This PR makes it possible by using the same object pattern that is used on other components (and also the <table> element). I’ve updated the nunjucks template as well as the YAML and the README to reflect the new functionality.
jonheslop
force-pushed
the
add-support-for-attributes-on-table-cells
branch
from
3c77f32 to
5d9b8fd
Compare
kr8n3r
approved these changes
Oct 29, 2018
jonheslop
force-pushed
the
add-support-for-attributes-on-table-cells
branch
2 times, most recently
from
362aff3 to
c255929
Compare
NickColley
approved these changes
Oct 29, 2018
|
Yay! Thanks :D |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It’s currently not possible to attach HTML attributes to table cells.
This PR makes it possible by using the same object pattern that is used
on other components (and also the
<table>element).I’ve updated the nunjucks template as well as the YAML and the README
to reflect the new functionality.
Background
Whilst migrating https://github.com/alphagov/pay-selfservice I’ve tried to use macros where ever possible, but we regularly use ID’s on cells within table so that our various tests can easily get the value.