Simplify button types to avoid unnecessary type attribute #1538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1538
36degrees
approved these changes
Aug 28, 2019
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1538
The button element as an implicit type of submit if it it's not set, since this is what most people need this change reduces a bit of markup for people to copy and paste.
NickColley
force-pushed
the
simplify-buttons-default
branch
from
5056898
to
f7c8917
Compare
Merged
stephencdaly
added a commit
to alphagov/pay-selfservice
that referenced
this pull request
Oct 7, 2019
govuk-frontend v3.1.0 removed the default type attribute on the button element as it was unnecessary. alphagov/govuk-frontend#1538 Some of our cypress tests used the type attribute in the selector, so remove this to get them passing.
stephencdaly
added a commit
to alphagov/pay-products-ui
that referenced
this pull request
Oct 7, 2019
govuk-frontend v3.1.0 removed the default type attribute on the button element as it was unnecessary. alphagov/govuk-frontend#1538 Some of our tests used the type attribute in the selector, so remove this to get them passing.
stephencdaly
added a commit
to alphagov/pay-selfservice
that referenced
this pull request
Oct 9, 2019
govuk-frontend v3.1.0 removed the default type attribute on the button element as it was unnecessary. alphagov/govuk-frontend#1538 Some of our cypress tests used the type attribute in the selector, so remove this to get them passing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The button element as an implicit type of submit if it it's not set, since this is what most people need this change reduces a bit of markup for people to copy and paste.
Markup before
Markup After