Skip to content

Commit

Permalink
BAU Fix failing tests
Browse files Browse the repository at this point in the history
govuk-frontend v3.1.0 removed the default type attribute on the button
element as it was unnecessary.

alphagov/govuk-frontend#1538

Some of our tests used the type attribute in the selector, so remove
this to get them passing.
  • Loading branch information
stephencdaly committed Oct 7, 2019
1 parent 10874d7 commit 266ce71
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ describe('product reference index controller', function () {
expect($('form').attr('action')).to.equal(`/pay/reference/${product.external_id}`)
expect($('.govuk-label').text()).to.include('Test reference label')
expect($('#payment-reference-hint').text()).to.include('Test reference hint')
expect($('button[type=submit]').text()).to.include('Continue')
expect($('button').text()).to.include('Continue')
})
})

Expand Down Expand Up @@ -168,7 +168,7 @@ describe('product reference index controller', function () {
it('should render product reference start page with Welsh text and the Welsh service name', () => {
expect($('title').text()).to.include(service.service_name.cy)
expect($('.govuk-header__content').text()).to.include(service.service_name.cy)
expect($('button[type=submit]').text()).to.include('Parhau')
expect($('button').text()).to.include('Parhau')
})
})

Expand Down Expand Up @@ -205,7 +205,7 @@ describe('product reference index controller', function () {
it('should render product reference start page with Welsh text and the English service name', () => {
expect($('title').text()).to.include(service.service_name.en)
expect($('.govuk-header__content').text()).to.include(service.service_name.en)
expect($('button[type=submit]').text()).to.include('Parhau')
expect($('button').text()).to.include('Parhau')
})
})
})

0 comments on commit 266ce71

Please sign in to comment.