Stop IE8 from downloading GDS Transport font #1559
Merged
+44
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The font paths were breaking in IE8 as we since v3 we're no longer postfixing them with `?#iefix`. As we removed the EOT files in v3 to stop serving GDS Transport font files to IE8 (see ), this commit removes the font faces from the IE8 stylesheet. This means that IE8 will fall back to system fonts, in this case Arial or sans-serif. Our previous approach of postfixing `?#iefix` wouldn't work here as IE8 would end up downloading the WOFF files which it cannot render. The downside of this approach is that the IE8 stylesheet still says ``` font-family: "GDS Transport", Arial, sans-serif; ``` which could be confusing. An alternative would have been define a new font family for IE8 at the `settings` level. See https://github.com/alphagov/govuk-frontend/compare/fix-ie8-fonts-alt-approach This also imports the IE8 tools for testing `govuk-typography-common`.
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1559
NickColley
reviewed
Sep 6, 2019
| @@ -130,6 +131,28 @@ describe('@mixin govuk-typography-common', () => { | |||
| expect(resultsString).toContain(`font-family: "GDS Transport"`) | |||
| expect(resultsString).toContain(`font-family: "GDS Transport"`) | |||
| }) | |||
| it('should not output a @font-face declaration when the browser is IE8', async () => { | |||
36degrees
approved these changes
Sep 9, 2019
There was a problem hiding this comment.
Seems like a sensible approach to me – top stuff @hannalaakso 👍
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internet Explorer 8 was making unsuccessful requests for the new font files because 3.0.0 no longer postfixes them with
?#iefixas we did in v2.3.0.0 dropped support for rendering GDS Transport for IE8. This PR removes the
font-facedeclarations from the IE8 stylesheet to stop IE8 trying to unsuccessfully to download the font files. This means that IE8 will fall back to system fonts (Arialby default). Our previous approach of postfixing the paths with?#iefixwouldn't work here as IE8 would still download the redundant WOFF files.The downside of this new approach is that
GDS Transportis still shown infont-familyin the IE8 stylesheet.I've also tried an alternative approach that sets
font-familyfor IE8 on a higher level and removes the above issue, but has other downsides.This also imports the IE8 tools for
govuk-typography-commontests, and tests thatfont-faceis not declared for IE8.Fixes #1550