Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop IE8 from downloading GDS Transport font #1559

Merged
merged 3 commits into from
Sep 9, 2019
Merged

Commits on Sep 6, 2019

  1. Exclude rendering GDS Transport font faces in IE8

    The font paths were breaking in IE8 as we since v3 we're no longer postfixing
    them with `?#iefix`.
    
    As we removed the EOT files in v3 to stop serving GDS Transport font files to IE8 (see ),
    this commit removes the font faces from the IE8 stylesheet. This means that IE8 will fall
    back to system fonts, in this case Arial or sans-serif.
    
    Our previous approach of postfixing `?#iefix` wouldn't work here as IE8 would end up
    downloading the WOFF files which it cannot render.
    
    The downside of this approach is that the IE8 stylesheet still says
    ```
    font-family: "GDS Transport", Arial, sans-serif;
    ```
    which could be confusing.
    
    An alternative would have been define a new font family for IE8 at the `settings` level.
    See https://github.com/alphagov/govuk-frontend/compare/fix-ie8-fonts-alt-approach
    
    This also imports the IE8 tools for testing `govuk-typography-common`.
    hannalaakso committed Sep 6, 2019
    Configuration menu
    Copy the full SHA
    f76f584 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b8f5bae View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2019

  1. Update changelog

    hannalaakso committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    4bcdee6 View commit details
    Browse the repository at this point in the history