Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add modifiers for table captions #2048

Merged
merged 1 commit into from
Feb 8, 2021
Merged

Add modifiers for table captions #2048

merged 1 commit into from
Feb 8, 2021

Conversation

frankieroberto
Copy link
Contributor

This makes table captions consistent with fieldset legends and labels, in having modifiers which apply the typographic styles equivalent to headings.

Resolves issue 1405.

@36degrees 36degrees added the awaiting triage Needs triaging by team label Dec 1, 2020
@trang-erskine trang-erskine added 🕔 hours A well understood issue which we expect to take less than a day to resolve. table and removed awaiting triage Needs triaging by team labels Dec 7, 2020
@CharlotteDowns CharlotteDowns self-requested a review December 7, 2020 14:41
CharlotteDowns
CharlotteDowns reviewed Dec 7, 2020
View reviewed changes
Copy link
Contributor

@CharlotteDowns CharlotteDowns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a really good addition. I've left a few comments but you may have chosen to not do them intentionally based on the context. Let me know what you think and thanks again :).

src/govuk/components/table/_index.scss Show resolved Hide resolved
src/govuk/components/table/_index.scss Show resolved Hide resolved
src/govuk/components/table/_index.scss Show resolved Hide resolved
@36degrees
Copy link
Contributor

Do we need to update the Design System tables guidance to document these new classes?

@frankieroberto
Copy link
Contributor Author

@36degrees I think it makes sense to mention these options on the table component page?

I'd be tempted to make the default example on that page using a larger caption size too.

@36degrees 36degrees mentioned this pull request Dec 22, 2020
Closed
2 tasks
@frankieroberto @36degrees
Add modifiers for table captions
a20ffa8 
This makes table captions consistent with fieldset headings and labels, in having modifiers which apply the typographic styles equivalent to headings.
@36degrees 36degrees force-pushed the add-modifiers-for-table-caption branch from 6b7cd7f to a20ffa8 Compare January 8, 2021 15:21
@CharlotteDowns CharlotteDowns mentioned this pull request Jan 12, 2021
Closed
@36degrees 36degrees added this to the v3.11.0 milestone Jan 25, 2021
@36degrees 36degrees merged commit 97e6a09 into alphagov:master Feb 8, 2021
@hannalaakso hannalaakso mentioned this pull request Feb 8, 2021
Merged
@frankieroberto frankieroberto deleted the add-modifiers-for-table-caption branch February 8, 2021 16:07
@christopherthomasdesign christopherthomasdesign mentioned this pull request Feb 11, 2021
Merged
This was referenced Mar 16, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlotteDowns CharlotteDowns CharlotteDowns approved these changes

@36degrees 36degrees 36degrees approved these changes

Assignees
No one assigned
Labels
🕔 hours A well understood issue which we expect to take less than a day to resolve. table
Projects
GOV.UK Design System cycle board
Archived in project
Milestone
v3.11.0
Development

Successfully merging this pull request may close these issues.

Table caption styling is unclear
4 participants
@frankieroberto @36degrees @CharlotteDowns @trang-erskine