Move font style to section-button in accordion
#2514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36degrees
approved these changes
Jan 25, 2022
There was a problem hiding this comment.
Thanks very much @JoshuaLicense – these changes look good to me 👍🏻
This just needs another review from our team before we can get this merged.
owenatgov
approved these changes
Jan 25, 2022
There was a problem hiding this comment.
Looks good ot me too 👍🏻 Thanks @JoshuaLicense! This just needs the changelog conflict resolved and we're good to go.
added 2 commits
January 25, 2022 20:29
The accordion heading text is not styled while JavaScript (JS) is disabled. `govuk-accordion__section-heading-text` is styled but that element only exists while JS is enabled. Remove font from `govuk-accordion__section-toggle` to reduce duplicate styles.
JoshuaLicense
force-pushed
the
move-font-style-to-govuk-accordion-section-button
branch
from
a9c6630
to
a4ec7b7
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The accordion heading text is currently not styled when JavaScript (JS) is disabled. Current font styling applies to
govuk-accordion__section-heading-text, but that element only exists when JS is enabled.This MR:
govuk-font()macro togovuk-accordion__section-button.govuk-font()fromgovuk-accordion__section-toggleand replaces with the explicit macrosgovuk-typography-responsive($size: 19)&govuk-typography-weight-regular- to reduce the font property duplication;govuk-accordion__section-togglewill inherit the font properties fromgovuk-accordion__section-button.Closes #2481
Happy to make any changes if required.