Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move font style to section-button in accordion #2514

Merged
merged 2 commits into from
Jan 26, 2022
Merged

Move font style to section-button in accordion #2514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb6d9f0
Move font style to `section-button` in accordion
Jan 21, 2022
a4ec7b7
Add CHANGELOG entry
Jan 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ This change was introduced in [#2491: Prevent error summary from being re-focuse
- [#2491: Prevent error summary from being re-focused after it has been initially focused on page load](https://github.com/alphagov/govuk-frontend/pull/2491)
- [#2494: Allow disabling autofocus on error summary](https://github.com/alphagov/govuk-frontend/pull/2494)
- [#2515: Add explicit width to summary list row with no actions pseudoelement](https://github.com/alphagov/govuk-frontend/pull/2515)
- [#2514: Fix accordion heading style while JavaScript is disabled](https://github.com/alphagov/govuk-frontend/pull/2514)

## 4.0.0 (Breaking release)

Expand Down
8 changes: 3 additions & 5 deletions src/govuk/components/accordion/_index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,17 +22,14 @@
}

.govuk-accordion__section-button {
@include govuk-font($size: 24, $weight: bold);
@include govuk-text-colour;

display: block;
margin-bottom: 0;
padding-top: govuk-spacing(3);
}

.govuk-accordion__section-heading-text {
@include govuk-font($size: 24, $weight: bold);
}

// Remove the bottom margin from the last item inside the content
.govuk-accordion__section-content > :last-child {
margin-bottom: 0;
Expand Down Expand Up @@ -297,7 +294,8 @@

// Add toggle link with Chevron icon on left.
.govuk-accordion__section-toggle {
@include govuk-font($size: 19);
@include govuk-typography-responsive($size: 19);
@include govuk-typography-weight-regular;
color: $govuk-link-colour;
}

Expand Down