Fix error with child maintenance example #3880
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -43,7 +43,7 @@ scenario: >- | |||
| tag: { | |||
| text: "beta" | |||
| }, | |||
| html: "This is a new service – your <a class="govuk-link" href="#">feedback</a> will help us to improve it." | |||
| html: "This is a new service – your <a class='govuk-link' href='#'>feedback</a> will help us to improve it." | |||
There was a problem hiding this comment.
Ahh nice spot
Would you mind if we always used double quotes in HTML?
Nunjucks doesn't mind single quotes, and we tend to use them when they enclose double quotes
Suggested change
| html: "This is a new service – your <a class='govuk-link' href='#'>feedback</a> will help us to improve it." | |
| html: 'This is a new service – your <a class="govuk-link" href="#">feedback</a> will help us to improve it.' |
|
Closing as this is superseded by #3953 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A minor bug that got missed in a previous review. Swaps out quotes in the phase banner in the example so that it doesn't break the html string.