Port exit this page from 4.7 #3953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinrotherham
suggested changes
Jul 12, 2023
There was a problem hiding this comment.
Nicely done @owenatgov
Few minor snags but nothing big at all. I think we'd best split out non-port changes (like renaming selector properties) unless it was for consistency with v5
packages/govuk-frontend-review/src/views/full-page-examples/child-maintenance/index.njk
Outdated
Show resolved
Hide resolved
packages/govuk-frontend/src/govuk/components/exit-this-page/exit-this-page.yaml
Outdated
Show resolved
Hide resolved
packages/govuk-frontend/src/govuk/components/exit-this-page/exit-this-page.test.js
Outdated
Show resolved
Hide resolved
| it('navigates to the href of the button', async () => { | ||
| await goToComponent(page, 'exit-this-page') | ||
|
|
||
| const pathname = await page.$eval(buttonClass, el => el.getAttribute('href')) |
There was a problem hiding this comment.
Thanks for using Element APIs here versus HTMLAnchorElement.href
The const hrefpathname change makes good sense too
I know the compiler can be annoyingly pedantic 😣
packages/govuk-frontend/src/govuk/components/exit-this-page/exit-this-page.mjs
Outdated
Show resolved
Hide resolved
packages/govuk-frontend/src/govuk/components/exit-this-page/exit-this-page.mjs
Outdated
Show resolved
Hide resolved
| /** | ||
| * Initialise component | ||
| */ | ||
| init () { |
There was a problem hiding this comment.
Thanks for moving this higher up 😊
packages/govuk-frontend/src/govuk/components/exit-this-page/exit-this-page.mjs
Show resolved
Hide resolved
| exampleNames = Object.keys(await getExamples('exit-this-page')) | ||
| }) | ||
|
|
||
| it('passes accessibility tests', async () => { |
There was a problem hiding this comment.
Fab work. Cheers for moving the accessibility tests into the new format 🙌
owenatgov
force-pushed
the
port-exit-this-page-from-4.7
branch
from
2720429 to
e311884
Compare
owenatgov
force-pushed
the
port-exit-this-page-from-4.7
branch
from
e311884 to
fbe9a4e
Compare
owenatgov
force-pushed
the
port-exit-this-page-from-4.7
branch
from
fbe9a4e to
1eb79e7
Compare
owenatgov
force-pushed
the
port-exit-this-page-from-4.7
branch
from
1eb79e7 to
a97c54f
Compare
govuk-design-system-ci
had a problem deploying
to
govuk-frontend-pr-3953
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports the exit this page component from the 4.7.0 release to
main, including refactoring the js to ES2015 in line with #3771Includes changes from the following PRs:
htmlparameter to Exit this Page button #3878Additionally supersedes #3880
Fixes #3840