-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix divider width for small checkboxes #5114
Fix divider width for small checkboxes #5114
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cheers @colinrotherham! I double checked the history and couldn't find anything to suggest it needed to not exist. Just needs a second approval and a changelog entry and it can get merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seconded!
@colinrotherham Do you want to add a changelog entry, or have us do it?
Thanks @owenatgov @domoscargin Would you and the team mind adding a changelog entry please? Always feels strange writing my own thank you message |
b6023a6
to
800b043
Compare
Fix divider width for small checkboxes
Hello 👋
There might be some history behind this, but I noticed small checkboxes use the regular divider width (unlike radios)
This PR ensures checkboxes follow the same convention as radios and adds a new example
Before
After
History
Worth mentioning existing comments regarding divider widths:
And a similar mention of label wrapping (which affects dividers too)