Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix divider width for small checkboxes #5114

Merged
merged 5 commits into from
Jul 11, 2024

Conversation

colinrotherham
Copy link
Contributor

Hello 👋

There might be some history behind this, but I noticed small checkboxes use the regular divider width (unlike radios)

This PR ensures checkboxes follow the same convention as radios and adds a new example

Before

Before, small checkboxes without adjustments to divider width and margin

After

After, small checkboxes with adjustments to divider width and margin

History

  1. Dividers supported for Radios in GOV.UK Elements
  2. Dividers added to Radios in GOV.UK Frontend via PR #849
  3. Smaller Radios and Checkboxes added in PR #1125 with narrow divider widths in b645ac1
  4. Dividers added to Checkboxes in GOV.UK Frontend via PR #2151 without narrow divider widths

Worth mentioning existing comments regarding divider widths:

And a similar mention of label wrapping (which affects dividers too)

Copy link
Contributor

@owenatgov owenatgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers @colinrotherham! I double checked the history and couldn't find anything to suggest it needed to not exist. Just needs a second approval and a changelog entry and it can get merged.

@owenatgov owenatgov requested a review from a team July 5, 2024 11:32
Copy link
Contributor

@domoscargin domoscargin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seconded!

@colinrotherham Do you want to add a changelog entry, or have us do it?

@colinrotherham
Copy link
Contributor Author

colinrotherham commented Jul 11, 2024

Thanks @owenatgov @domoscargin

Would you and the team mind adding a changelog entry please?

Always feels strange writing my own thank you message

@domoscargin domoscargin merged commit 46df0c7 into alphagov:main Jul 11, 2024
47 checks passed
@romaricpascal romaricpascal mentioned this pull request Jul 12, 2024
querkmachine pushed a commit that referenced this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants