Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix divider width for small checkboxes #5114

Merged
merged 5 commits into from
Jul 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ This change was introduced in [pull request #4995: Update Breadcrumb component t

We've made fixes to GOV.UK Frontend in the following pull requests:

- [#5114: Fix divider width for small checkboxes](https://github.com/alphagov/govuk-frontend/pull/5114) – thanks to [@colinrotherham](https://github.com/colinrotherham)
- [#5043: Refactor the accordion JavaScript](https://github.com/alphagov/govuk-frontend/pull/5043)
- [#5044: Remove session storage checks from accordion JavaScript](https://github.com/alphagov/govuk-frontend/pull/5044)
- [#5060: Reintroduce additional bottom margin to Error Summary content](https://github.com/alphagov/govuk-frontend/pull/5060)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,11 @@
padding-left: ($govuk-touch-target-size - $input-offset) - ($margin-left + $conditional-border-width);
}

.govuk-checkboxes__divider {
width: $govuk-small-checkboxes-size;
margin-bottom: govuk-spacing(1);
}

// Hover state for small checkboxes.
//
// We use a hover state for small checkboxes because the touch target size
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,7 @@ examples:
- other

- name: with divider and None
screenshot: true
options:
name: with-divider-and-none
fieldset:
Expand Down Expand Up @@ -700,6 +701,26 @@ examples:
- value: b
text: another thing

- name: small with divider and None
screenshot: true
options:
name: small-with-divider-and-none
classes: govuk-checkboxes--small
fieldset:
legend:
text: Which types of waste do you transport regularly?
items:
- value: animal
text: Waste from animal carcasses
- value: mines
text: Waste from mines or quarries
- value: farm
text: Farm or agricultural waste
- divider: or
- value: none
text: None of these
behaviour: exclusive

# Hidden examples are not shown in the review app, but are used for tests and HTML fixtures
- name: with idPrefix
hidden: true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -242,14 +242,15 @@ examples:
For properties that are within a geographical area defined by a local council

- name: with a divider
screenshot: true
options:
idPrefix: example-divider
name: example
fieldset:
legend:
text: How do you want to sign in?
items:
- value: governement-gateway
- value: government-gateway
text: Use Government Gateway
- value: govuk-verify
text: Use GOV.UK Verify
Expand Down Expand Up @@ -680,6 +681,7 @@ examples:
text: funkiness

- name: small with a divider
screenshot: true
options:
idPrefix: example-small-divider
name: example
Expand All @@ -688,7 +690,7 @@ examples:
text: How do you want to sign in?
classes: govuk-radios--small
items:
- value: governement-gateway
- value: government-gateway
text: Use Government Gateway
- value: govuk-verify
text: Use GOV.UK Verify
Expand Down