Allow custom image and font URL helpers #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-733
36degrees
force-pushed
the
allow-custom-image-font-functions
branch
from
2c76b14 to
d08fe73
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-733
36degrees
force-pushed
the
allow-custom-image-font-functions
branch
from
d08fe73 to
89da660
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-733
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-733
tijmenb
added a commit
to alphagov/govuk_publishing_components
that referenced
this pull request
May 30, 2018
36degrees
changed the title
NickColley
approved these changes
May 30, 2018
There was a problem hiding this comment.
This looks really good.
Do we need to add some more documentation on how to use this?
If someone ran into the problem Tijmen did, where would they look?
Optionally would like an example/ that proves this works with the Rails asset pipeline, but we can consider that later.
|
I'd expect it to be documented as part of https://github.com/alphagov/govuk-frontend/blob/doc-updates/docs/installation/installing-with-npm.md#import-images, but waiting for that branch to be merged first. |
|
Going to merge this and we can add the docs later. |
3 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to set custom functions to resolve image and font urls.
Proposing this as a solution to #730.
Closes #730