Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPIKE] Use GOV.UK Frontend for buttons #328

Closed
wants to merge 10 commits into from

Conversation

tijmenb
Copy link
Contributor

@tijmenb tijmenb commented May 18, 2018

This uses the latest version of GOV.UK Frontend to render the buttons. GOV.UK Frontend is still in private beta, but this PR is mainly to see how we might consume the project (since it's The Future).

Some observations:

  • I've added a package.json and added govuk_frontend package. We need to commit all of the package, but pulling in individual components works nicely. Images can be easily added to the asset pipeline 👌
  • The new button is slightly larger than our button, but it looks okay.
    screen shot 2018-05-18 at 16 36 02
  • Our button component has more features than the component from GOV.UK Frontend. Namely we support a bottom margin and an "Info text" below the button. I've kept the existing classes for these, but it's quite weird to mix (govuk-button, gem-c-button).

Open issues

https://trello.com/c/L9Lhqngb

@tijmenb tijmenb temporarily deployed to govuk-publishing-compon-pr-328 May 18, 2018 15:37 Inactive
@tijmenb tijmenb changed the title [Don't merge] Use GOV.UK Frontend for buttons [SPIKE] Use GOV.UK Frontend for buttons May 24, 2018
@tijmenb tijmenb temporarily deployed to govuk-publishing-compon-pr-328 May 29, 2018 12:25 Inactive
@tijmenb tijmenb temporarily deployed to govuk-publishing-compon-pr-328 May 30, 2018 09:20 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant