Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Create layout component for admin apps #371

Closed
wants to merge 1 commit into from
Closed

[WIP] Create layout component for admin apps #371

wants to merge 1 commit into from

Conversation

tijmenb
Copy link
Contributor

@tijmenb tijmenb commented Jun 11, 2018 •
edited
Loading

This PR creates a template for admin apps using GOV.UK Frontend, split up in 4 components.

This layout will be used by the Release app in alphagov/release#228, and is intended to be used after that by the new publisher workflow app, organisations publisher and an app to manage content.

This follows on earlier spikes #328 and #331, which were used to identify how we might consume GOV.UK Frontend.

Preview

screen shot 2018-06-11 at 16 38 30

https://trello.com/c/09fVPrRN

@tijmenb tijmenb temporarily deployed to govuk-publishing-compon-pr-371 June 11, 2018 15:40 Inactive
@tijmenb tijmenb force-pushed the layout-for-admin-apps branch from f45ec2d to 0c8dd71 Compare June 11, 2018 15:42
@tijmenb tijmenb temporarily deployed to govuk-publishing-compon-pr-371 June 11, 2018 15:42 Inactive
@tijmenb tijmenb force-pushed the layout-for-admin-apps branch from 0c8dd71 to 08f7e16 Compare June 11, 2018 15:45
@tijmenb tijmenb temporarily deployed to govuk-publishing-compon-pr-371 June 11, 2018 15:46 Inactive
@tijmenb tijmenb force-pushed the layout-for-admin-apps branch from 08f7e16 to 97dc452 Compare June 11, 2018 15:56
@tijmenb tijmenb temporarily deployed to govuk-publishing-compon-pr-371 June 11, 2018 15:56 Inactive
@tijmenb tijmenb changed the title Create layout component for admin apps [WIP] Create layout component for admin apps Jun 15, 2018
@tijmenb tijmenb force-pushed the layout-for-admin-apps branch 4 times, most recently from a8e9467 to 753c384 Compare June 21, 2018 15:45
@tijmenb tijmenb had a problem deploying to govuk-publishing-compon-pr-371 June 21, 2018 15:52 Failure
@tijmenb tijmenb had a problem deploying to govuk-publishing-compon-pr-371 June 21, 2018 21:16 Failure
@tijmenb tijmenb had a problem deploying to govuk-publishing-compon-pr-371 June 21, 2018 21:19 Failure
@tijmenb tijmenb had a problem deploying to govuk-publishing-compon-pr-371 June 21, 2018 21:43 Failure
@tijmenb tijmenb temporarily deployed to govuk-publishing-compon-pr-371 June 21, 2018 21:46 Inactive
@tijmenb tijmenb temporarily deployed to govuk-publishing-compon-pr-371 June 21, 2018 21:51 Inactive
@tijmenb tijmenb temporarily deployed to govuk-publishing-compon-pr-371 July 2, 2018 17:13 Inactive
@tijmenb tijmenb force-pushed the layout-for-admin-apps branch from e2bdfef to 869a403 Compare July 3, 2018 11:40
@tijmenb tijmenb mentioned this pull request Jul 10, 2018
Merged
@tijmenb tijmenb force-pushed the layout-for-admin-apps branch from 869a403 to 5ffc981 Compare July 10, 2018 13:20
@tijmenb
Copy link
Contributor Author

tijmenb commented Jul 10, 2018

This PR is going to be split up in multiple PRs.

@tijmenb tijmenb closed this Jul 10, 2018
@vanitabarrett vanitabarrett mentioned this pull request Jul 11, 2018
Merged
@barrucadu barrucadu deleted the layout-for-admin-apps branch January 2, 2019 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vanitabarrett vanitabarrett Awaiting requested review from vanitabarrett

@andysellick andysellick Awaiting requested review from andysellick

@maxgds maxgds Awaiting requested review from maxgds

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tijmenb