Make Travis deployment config consistent #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you mean to link to the before_deploy documentation in the commit message? |
36degrees
approved these changes
Feb 24, 2017
With other GDS FE repos, see: alphagov/govuk_frontend_toolkit#385 Steps specified in before_deploy are only run if a deployment is triggered [1], which will only happen on master, which can't be done by a user without write perms. [1] [Travis before_deploy documentation](https://docs.travis-ci.com/user/deployment/npm/#Running-commands-before-and-after-deploy)
dsingleton
force-pushed
the
travis-deploy-install
branch
from
55c84db to
096cf1b
Compare
I did - bad copy and paste. Fixed in the commit and PR. 👍 |
|
LGTM, thanks @dsingleton and @36degrees |
dsingleton
added a commit
that referenced
this pull request
Mar 7, 2017
This was broken in #408, where the setup was moved to `before_deploy` to avoid permission issues when running PR tests in a way consistent with other alphagov apps. Previously that was guarded by a shell if, which was remvoved, but a bit at the end was left and is breaking deployment builds. :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With other GDS FE repos, see:
alphagov/govuk_frontend_toolkit#385
Steps specified in before_deploy are only run if a deployment is
triggered [1], which will only happen on master, which can't be
done by a user without write perms.
[1] Travis before_deploy documentation