Revert Make Travis deployment config consistent #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsingleton
approved these changes
Mar 7, 2017
gemmaleigh
added a commit
to alphagov/govuk_frontend_toolkit
that referenced
this pull request
Mar 17, 2017
Moves the open_ssl command back to before_install, otherwise it runs more than once (as there is more than one deploy provider). Related Travis issue here: travis-ci/travis-ci#2570 This behaviour was reverted in GOV.UK elements here: alphagov/govuk_elements#415 Before deploying, also check that the build has passed successfully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does the pull request solve?
This PR attempts to fix deployment to Heroku, which is currently failing.
This reverts the changes made in #404:
#408
It moves the open_ssl command back to before_install, otherwise it runs more than once (as
there is more than one deploy provider).
See related issue here:
travis-ci/travis-ci#2570
What type of change is it?