Merge pull request #4184 from alphagov/fix-background-color-unset

Replace 'unset' property in printed background colours
alphagov · Sep 2, 2024 · 422e139 · 422e139
2 parents 7a0a5ef + e635ea9
commit 422e139
Show file tree

Hide file tree

Showing 16 changed files with 19 additions and 18 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -10,6 +10,7 @@
 ## Unreleased
 
 * Fix the search toggle in layout header ([PR #4163](https://github.com/alphagov/govuk_publishing_components/pull/4163))
+* Replace 'unset' property in printed background colours ([PR #4184](https://github.com/alphagov/govuk_publishing_components/pull/4184))
 
 ## 43.0.1
 

diff --git a/app/assets/stylesheets/component_guide/application.scss b/app/assets/stylesheets/component_guide/application.scss
@@ -139,7 +139,7 @@ $gem-guide-border-width: 1px;
 
   @include govuk-media-query($media-type: print) {
     &[class*="-background"] {
-      background-color: unset;
+      background: none;
     }
   }
 }

diff --git a/app/assets/stylesheets/govuk_publishing_components/components/_cross-service-header.scss b/app/assets/stylesheets/govuk_publishing_components/components/_cross-service-header.scss
@@ -443,7 +443,7 @@ $govuk-header-link-underline-thickness: 3px;
   }
 
   .gem-c-one-login-header {
-    background-color: initial;
+    background: none;
     border-bottom: 2pt solid $govuk-print-text-colour;
 
     * {
@@ -456,6 +456,8 @@ $govuk-header-link-underline-thickness: 3px;
   }
 
   .gem-c-service-header {
+    background: none;
+
     .govuk-width-container {
       margin: 0;
     }

diff --git a/app/assets/stylesheets/govuk_publishing_components/components/_intervention.scss b/app/assets/stylesheets/govuk_publishing_components/components/_intervention.scss
@@ -26,7 +26,7 @@
 @include govuk-media-query($media-type: print) {
   .gem-c-intervention {
     break-inside: avoid;
-    background-color: transparent;
+    background: none;
     border-color: $govuk-print-text-colour;
 
     .govuk-body {

diff --git a/app/assets/stylesheets/govuk_publishing_components/components/_inverse-header.scss b/app/assets/stylesheets/govuk_publishing_components/components/_inverse-header.scss
@@ -30,7 +30,7 @@
 
 @include govuk-media-query($media-type: print) {
   .gem-c-inverse-header {
-    background-color: unset;
+    background: none;
     border-bottom: 2pt solid $govuk-print-text-colour;
 
     &,

diff --git a/app/assets/stylesheets/govuk_publishing_components/components/_layout-header.scss b/app/assets/stylesheets/govuk_publishing_components/components/_layout-header.scss
@@ -183,7 +183,7 @@
     .gem-c-header__product-name,
     .gem-c-environment-tag {
       color: $govuk-print-text-colour;
-      background-color: unset;
+      background: none;
     }
   }
 }
diff --git a/...s/stylesheets/govuk_publishing_components/components/_layout-super-navigation-header.scss b/...s/stylesheets/govuk_publishing_components/components/_layout-super-navigation-header.scss
@@ -989,7 +989,7 @@ $after-button-padding-left: govuk-spacing(4);
     border-top: 0;
     border-bottom: 2pt solid $govuk-print-text-colour;
     margin: 0 0 5mm;
-    background-color: transparent;
+    background: none;
 
     &:has(.gem-c-layout-super-navigation-header__header-logo .govuk-visually-hidden) {
       border: 0;

diff --git a/app/assets/stylesheets/govuk_publishing_components/components/_metadata.scss b/app/assets/stylesheets/govuk_publishing_components/components/_metadata.scss
@@ -100,7 +100,7 @@
   .gem-c-metadata {
     break-inside: avoid;
     color: $govuk-print-text-colour !important;
-    background-color: unset;
+    background: none;
     margin-bottom: 5mm;
 
     a,

diff --git a/app/assets/stylesheets/govuk_publishing_components/components/_phase-banner.scss b/app/assets/stylesheets/govuk_publishing_components/components/_phase-banner.scss
@@ -32,7 +32,7 @@
   .gem-c-phase-banner {
     &,
     & * {
-      background-color: unset !important;
+      background: none !important;
       color: $govuk-print-text-colour !important;
     }
 

diff --git a/app/assets/stylesheets/govuk_publishing_components/components/_step-by-step-nav-header.scss b/app/assets/stylesheets/govuk_publishing_components/components/_step-by-step-nav-header.scss
@@ -22,7 +22,7 @@
 @include govuk-media-query($media-type: print) {
   .gem-c-step-nav-header {
     padding: 0 0 govuk-spacing(4) 0;
-    background: unset;
+    background: none;
     border-color: $govuk-print-text-colour;
   }
 

diff --git a/app/assets/stylesheets/govuk_publishing_components/components/_step-by-step-nav-related.scss b/app/assets/stylesheets/govuk_publishing_components/components/_step-by-step-nav-related.scss
@@ -48,7 +48,7 @@
 // stylelint-disable declaration-no-important
 @include govuk-media-query($media-type: print) {
   .gem-c-step-nav-related {
-    background: unset;
+    background: none;
     border-color: $govuk-print-text-colour;
   }
 

diff --git a/app/assets/stylesheets/govuk_publishing_components/components/_success-alert.scss b/app/assets/stylesheets/govuk_publishing_components/components/_success-alert.scss
@@ -9,7 +9,7 @@
 @include govuk-media-query($media-type: print) {
   .gem-c-success-alert {
     break-inside: avoid;
-    background-color: initial;
+    background: none;
     border-color: $govuk-print-text-colour;
 
     * {

diff --git a/app/assets/stylesheets/govuk_publishing_components/components/_table.scss b/app/assets/stylesheets/govuk_publishing_components/components/_table.scss
@@ -133,7 +133,7 @@ $table-row-even-background-colour: govuk-colour("light-grey");
 
     * {
       color: $govuk-print-text-colour !important;
-      background-color: initial !important;
+      background: none !important;
     }
 
     .govuk-table__header,

diff --git a/app/assets/stylesheets/govuk_publishing_components/components/_warning-text.scss b/app/assets/stylesheets/govuk_publishing_components/components/_warning-text.scss
@@ -28,7 +28,7 @@
   }
 
   .govuk-warning-text__icon {
-    background-color: transparent;
+    background: none;
     color: $govuk-print-text-colour;
   }
 }
diff --git a/app/assets/stylesheets/govuk_publishing_components/components/govspeak/_button.scss b/app/assets/stylesheets/govuk_publishing_components/components/govspeak/_button.scss
@@ -32,7 +32,7 @@
 
       &,
       & * {
-        background-color: unset;
+        background: none;
         color: $govuk-print-text-colour !important; // stylelint-disable-line declaration-no-important
       }
 

diff --git a/...assets/stylesheets/govuk_publishing_components/components/govspeak/_highlight-answer.scss b/...assets/stylesheets/govuk_publishing_components/components/govspeak/_highlight-answer.scss
@@ -44,15 +44,13 @@ $highlight-answer-color: govuk-colour("white");
       }
     }
 
-    // stylelint-disable declaration-no-important
     @include govuk-media-query($media-type: print) {
-      background-color: unset;
+      background: none;
 
       &,
       & * {
-        color: $govuk-print-text-colour !important;
+        color: $govuk-print-text-colour !important; // stylelint-disable-line declaration-no-important
       }
     }
-    // stylelint-enable declaration-no-important
   }
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -32,7 +32,7 @@ @@
           &,
           & * {
-            background-color: unset;
+            background: none;
             color: $govuk-print-text-colour !important; // stylelint-disable-line declaration-no-important
           }
@@ Expand Down @@