Replace 'unset' property in printed background colours #4184
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
In improving print styles in gem components (#4073), we used
background-color: unset
to revert backgrounds to transparent for print. This would ensure that inverse components would always print non-inverted, saving ink.After discussion we decided to change this to use
background: none
instead, because:unset
is uncommon and not well understood, and its behaviour can be unpredictablebackground: none
is a more common accepted approach and easier to understand. We've taken into account that resetting all background properties can be considered a CSS anti-pattern, however we're confident in this case that it won't have any adverse effects because we're not using any other background properties in the affected components.This PR also makes consistent other treatments of background, such as
background-color: transparent
orbackground: initial
.Trello