Remove lists from summary list action links #1956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andysellick
changed the title
danacotoran
approved these changes
Mar 8, 2021
spec/components/summary_list_spec.rb
Outdated
| edit: { | ||
| href: "#edit-title", | ||
| data_attributes: { | ||
| gtm: "edit-title", |
There was a problem hiding this comment.
I wonder if it makes sense to also check for data attributes when testing that the actions are rendered as a list.
Since there is another test that checks that they're rendered with data attributes when they are alone, is it necessary to also have that in this test?
There was a problem hiding this comment.
Good shout, removed.
andysellick
force-pushed
the
remove-summary-action-list
branch
from
c5a7f20 to
7d421bd
Compare
- when the summary list has more than one action i.e. edit and delete, it makes sense for them to be contained within a list inside the DD - when there is only one action, there is no need for a single item to be contained in a list - this was raised as an accessibility problem in a recent audit of accounts
- when the summary list has more than one action (at the top of the component) i.e. edit and delete, it makes sense for them to be contained within a list - when there is only one action, there is no need for a single item to be contained in a list - add tests for this functionality, as seem to be previously missing - this was raised as an accessibility problem in a recent audit of accounts
andysellick
force-pushed
the
remove-summary-action-list
branch
from
7d421bd to
dc094eb
Compare
DilwoarH
pushed a commit
that referenced
this pull request
Mar 9, 2021
Merged
This was referenced Mar 11, 2021
Closed
Closed
Closed
This was referenced Mar 11, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Change how the edit/delete links are rendered in the summary list component. They were added inside a list, even if there was only one link. This change only renders the links inside a list if there is more than one of them.
This change applies to the links that can appear at the top of the component as well as the similar links that can appear on each row.
Why
This was highlighted in a recent accessibility audit where only one link was present in a summary list component. A single link (already in a DD element) doesn't need wrapping in a list.
Visual Changes
None. But here's an illustrative screenshot.
Trello card: https://trello.com/c/lNkwruEi/647-fix-accessibility-issues-raised-by-dac