Fix GOV.UK Frontend deprecation warning for component-guide print stylesheet #1961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andysellick / @alex-ju any chance I could get your thoughts on this alternative to #1934 ? |
alex-ju
approved these changes
Mar 8, 2021
kevindew
force-pushed
the
attempt-2-at-govuk-frontend-warning
branch
from
1fbce93 to
0312306
Compare
kevindew
changed the title
This file imports "govuk/base" which is required to resolve a GOV.UK
Frontend warning, as we are currently relying on implicit imports that
will be removed in the next major release.
Before:
```
I, [2021-03-08T10:25:39.692458 #79055] INFO -- : Writing /Users/kevindew/govuk/govuk_publishing_components/spec/dummy/public/assets/component_guide/visual-regression-7a6fbecb638d5f96b24d97212b0044b0b3d9e195c0ea5543612dba4347f5ec2e.js.gz
WARNING: Importing items from the core layer without first importing `base` is deprecated, and will no longer work as of GOV.UK Frontend v4.0.
on line 2:3 of node_modules/govuk-frontend/govuk/core/_links.scss
from line 1:9 of node_modules/govuk-frontend/govuk/core/_all.scss
from line 4:9 of app/assets/stylesheets/govuk_publishing_components/component_support.scss
from line 5:9 of app/assets/stylesheets/govuk_publishing_components/components/print/_accordion.scss
from line 6:9 of app/assets/stylesheets/govuk_publishing_components/_all_components_print.scss
from line 1:9 of app/assets/stylesheets/component_guide/print.scss
I, [2021-03-08T10:25:41.428470 #79055] INFO -- : Writing /Users/kevindew/govuk/govuk_publishing_components/spec/dummy/public/assets/component_guide/print-a0002005ec52f551aa28aa9e421e2cd6d1ab9c8cc06f4c1b7b50abd92dada192.css
I, [2021-03-08T10:25:41.428689 #79055] INFO -- : Writing /Users/kevindew/govuk/govuk_publishing_components/spec/dummy/public/assets/component_guide/print-a0002005ec52f551aa28aa9e421e2cd6d1ab9c8cc06f4c1b7b50abd92dada192.css.gz
```
After:
```
I, [2021-03-08T10:26:16.011247 #79155] INFO -- : Writing /Users/kevindew/govuk/govuk_publishing_components/spec/dummy/public/assets/component_guide/visual-regression-7a6fbecb638d5f96b24d97212b0044b0b3d9e195c0ea5543612dba4347f5ec2e.js.gz
I, [2021-03-08T10:26:17.598856 #79155] INFO -- : Writing /Users/kevindew/govuk/govuk_publishing_components/spec/dummy/public/assets/component_guide/print-a0002005ec52f551aa28aa9e421e2cd6d1ab9c8cc06f4c1b7b50abd92dada192.css
I, [2021-03-08T10:26:17.599218 #79155] INFO -- : Writing /Users/kevindew/govuk/govuk_publishing_components/spec/dummy/public/assets/component_guide/print-a0002005ec52f551aa28aa9e421e2cd6d1ab9c8cc06f4c1b7b50abd92dada192.css.gz
```
kevindew
force-pushed
the
attempt-2-at-govuk-frontend-warning
branch
from
0312306 to
9fc27cf
Compare
|
Thanks @alex-ju - I've updated the changelog now |
DilwoarH
pushed a commit
that referenced
this pull request
Mar 9, 2021
Merged
This was referenced Mar 11, 2021
Closed
Closed
Closed
This was referenced Mar 11, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file imports "govuk/base" which is required to resolve a GOV.UK Frontend warning. This is attempt 2 following #1934, this tries to be a more modest fix.
Before:
After: