Fix tracking in details.js #1962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`TrackClick` (provided by static) was recently replaced with `GemTrackClick` (provided by govuk_publishing_components) after the analytics script have been ported from static to govuk_publishing_components. This instance has been missed at that point, which causes JS to crash on certain pages across GOV.UK
andysellick
approved these changes
Mar 8, 2021
injms
approved these changes
Mar 8, 2021
Merged
This was referenced Mar 9, 2021
Closed
Closed
Closed
Closed
Closed
This was referenced Mar 17, 2021
This was referenced Mar 17, 2021
Closed
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix tracking in
details.jsWhy
TrackClick(provided by static) was recently replaced withGemTrackClick(provided by govuk_publishing_components) after the analytics scripts have been ported from static to govuk_publishing_components. This instance has been missed at that point, which causes JS to crash on certain pages across GOV.UK.Visual Changes
This issues has been reported by @ChrisBAshton as the JS crash stopped the video render script in
government-frontend