-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update design of metadata component #2046
Conversation
18b21cd
to
89fb156
Compare
Looks awesome. 👍🏽 |
89fb156
to
3085b96
Compare
I'm concerned about hiding the commas. In my terrible wrangling of VoiceOver I'm not seeing any difference between live and this, but I wonder if it might make things confusing for some. My concern is that rather than hearing "department of work and pensions comma home office comma hmrc" might you wind up with a word soup where the user has to try to work out where the delimiters are and getting it wrong? "department of work" and "pension home" "office". Blogs posts like this one tend to say leave things be if they sound a bit clunky as trying to fix them might make the issue worse: https://accessibility.blog.gov.uk/2017/02/08/advice-for-creating-content-that-works-well-with-screen-readers/ Maybe one to take to the capability team? |
@maxgds The reason I did this originally was on voice over, the dictation was reading each link and each comma separately, leaving this awkward pause. See video's for example of the problem vs the solution in VO (excuse messy recording): CurrentScreen.Recording.2021-05-05.at.16.11.13.movThis PRScreen.Recording.2021-05-05.at.16.10.04.movHowever, testing more extensively in other screen readers it does read stuff out as one continuous sentence which is confusing: Screen.Recording.2021-05-05.at.16.17.43.movMy gut feeling from extensive testing and your reasoning is that even though this problem persists on VO it isn't a problem in NVDA so maybe I should just revert it? What do you think? |
Sadly I think so. I know that there are different modes you can browse in with a screenreader and thought I was just failing to get VoiceOver to read the 'sentence' to me, but I did manage to get it to do so by highlighting it using my mouse. I recognise the effort here so I'm sorry to say it but I think it will introduce more confusion. |
3085b96
to
19915cd
Compare
@maxgds Not to worry, makes sense to me. Removed and updated the PR description |
app/assets/stylesheets/govuk_publishing_components/components/_metadata.scss
Outdated
Show resolved
Hide resolved
19915cd
to
79730fb
Compare
I'm hold off on merging this for a bit because there's a separate piece of work to inform content designers about this change. |
79730fb
to
62b5d80
Compare
What
Update's the design of the metadata block component along with some general tidying. The specifics:
Why
This design existed in government frontend but was accidentally overwritten by work by govuk accessibility during our component update work. This change benefits screen magnification users as it will be easier for them to reach information when zoomed in.
A more detailed note from our designer on why it was changed in the first place and why we want to re-update it and apply it everywhere:
Visual Changes